Skip to content

chore/SYNC-229/npm publish upgrade#27

Merged
shannamurry merged 2 commits intomainfrom
chore/SYNC-229
Nov 21, 2025
Merged

chore/SYNC-229/npm publish upgrade#27
shannamurry merged 2 commits intomainfrom
chore/SYNC-229

Conversation

@shannamurry
Copy link
Contributor

Upgrades NPM publishing to trusted publisher

@shannamurry shannamurry self-assigned this Nov 21, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @shannamurry, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the package's publishing workflow by adopting the trusted publisher mechanism for NPM. This involves a significant update to the required Node.js and NPM engine versions, ensuring the project aligns with current best practices for secure and efficient package distribution.

Highlights

  • NPM Publishing Upgrade: This pull request upgrades the NPM publishing process to utilize the trusted publisher feature, enhancing security and reliability for package distribution.
  • Node.js Version Update: The required Node.js version has been updated from ">=14" to ">=20" in package.json, and a new .node-version file specifies "20.19.4" for consistent environment setup.
  • NPM Engine Requirement: A new minimum NPM engine requirement of ">=11.5.1" has been added to package.json to ensure compatibility with the updated publishing process.
  • Package Version Bump: The package version has been incremented from "2.2.0" to "3.0.0", indicating a major release, likely due to the significant environment and publishing changes.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/publish.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@guardrails
Copy link

guardrails bot commented Nov 21, 2025

⚠️ We detected 3 security issues in this pull request:

Vulnerable Libraries (3)
Severity Details
High pkg:npm/cross-env@7.0.3 (t) upgrade to: > 7.0.3
High pkg:npm/@testing-library/jest-dom@5.16.4 (t) upgrade to: > 5.16.4
Critical pkg:npm/microbundle-crl@0.13.11 (t) upgrade to: > 0.13.11

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the project's Node.js and npm version requirements, including a major version bump to reflect the breaking change. The changes are generally good, but I've found a critical issue with the newly added .node-version file. The specified version 20.19.4 appears to be invalid, which will break common developer workflows that rely on tools like nvm. I've suggested a fix to make it a valid and more flexible version specifier.

@shannamurry shannamurry merged commit 5afceca into main Nov 21, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants