test: add test preventing 1W,2W regression#9
Merged
Kniggebrot merged 3 commits intomasterfrom Jan 7, 2025
Merged
Conversation
devices with the cron "0 0 12 1W,2W * ?" had problems on new years eve, triggering too often when they should only trigger once each day. This is a cronlib issue, as it seems to jump back in time to calculate the next W flag, but doesn't realize it went behind the original start point.
Such as for 1st of May 2025 (also a Wednesday?), and whether more "spaced out" weekdays `1W,15W` work as well
Aren't failing as W-checks were redone, inserting days dynamically into calendar instead of looking up the next fitting day for each flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In versions previous to October 2024,
1W,2Wand1W,3Win DOM field would cause CRONs to trigger as often as possible from 1st to 2nd/3rd,as
handle_w_dom()would always go to the 1st (and calculate from there) when it was in the checked W flag range, which starts up to 2 days before the current day.This bug was fixed unintentionally with the rework of W and L flag handling, but it would be good to include the tests to avoid regressions.