Skip to content

โœจ feat: reset random key to avoid ID conflicts during state parsing #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arvinxx merged 2 commits into from
Jan 8, 2026
Merged

โœจ feat: reset random key to avoid ID conflicts during state parsing #103

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5480234
โœจ feat: reset random key to avoid ID conflicts during state parsing
Jan 7, 2026
576a2b3
๐Ÿ› fix: ensure proper type handling for state node keys in JSONDataSource
Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/plugins/common/data-source/json-data-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
$isRangeSelection,
$isTextNode,
IS_CODE,
resetRandomKey,
} from 'lexical';
import { $getRoot } from 'lexical';

Expand Down Expand Up @@ -73,6 +74,13 @@ export default class JSONDataSource extends DataSource {
(state) => {
try {
const root = $parseSerializedNodeImpl(dataObj.root, editor, true, state);
let maxId = -1;
state._nodeMap.keys().forEach((key) => {
if (key === 'root') return;
maxId = Math.max(maxId, Number(key));
});
// make sure to reset random key to avoid id conflicts
resetRandomKey(maxId + 1);
state._nodeMap.set(root.getKey(), root);
} catch (error) {
console.error(error);
Expand Down
Loading