This repository was archived by the owner on Jun 7, 2025. It is now read-only.
[#88] Add Cache-Control headers for Apple touch icons#91
Open
vivshaw wants to merge 1 commit intolobsters:masterfrom
Open
[#88] Add Cache-Control headers for Apple touch icons#91vivshaw wants to merge 1 commit intolobsters:masterfrom
Cache-Control headers for Apple touch icons#91vivshaw wants to merge 1 commit intolobsters:masterfrom
Conversation
vivshaw
commented
Jun 2, 2025
| break; | ||
| } | ||
|
|
||
| location ~ ^/(apple-touch-icon|touch-icon).*\.png$ { |
Contributor
Author
There was a problem hiding this comment.
Do you want favicon.ico covered too? I noticed it also lacks Cache-Control headers. Left it off here 'cause you didn't explicitly mention it in the ticket, though.
vivshaw
changed the title
Cache-Control headers for Apple touch icons
Member
|
@vivshaw Thank you for trying to fix this. I'm very sorry to have wasted your time here, but with our move from ansible to hatchbox we've moved from nginx to Caddy. We'll have to see if this issue persists on the new setup and write caddy config to fix it, if so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue lobsters/lobsters#1614 by updating the Nginx config with cache headers for Apple touch icons.