fix: add return types #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hey @Adnan-cds I've added return types to pass the static analysis checks. I noticed the PHPUnit tests fail, could you look at these please as I'm not too familiar with this module. Looks like the last successful PHPUnit tests were 2 months ago, so not sure if the errors are related to this or something else. |
Merged
Adnan-cds
reviewed
Jan 23, 2025
Adnan-cds
reviewed
Jan 23, 2025
Adnan-cds
approved these changes
Jan 24, 2025
Contributor
Adnan-cds
left a comment
Adnan-cds
left a comment
There was a problem hiding this comment.
Thanks for the hard work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes failures in static analysis by adding return types