updating address dropdown when Drupal ajax request completes

[PardeepSinghBali]

What does this change?

This change ensures that the address dropdown (.js-address-select) is populated immediately after the search button (.js-address-searchbutton) is clicked. Previously, the dropdown did not update in real-time, requiring additional interaction or refreshes.
How does it solve the problem?
Listens for AJAX completion (ajaxComplete event).
Clears and repopulates the dropdown dynamically with returned addresses.
Ensures the dropdown is displayed after the search.

How to test

On this branch (PS_PopulateAddressInDDWithAjax)

Perform an address search.
The dropdown populates instantly with the retrieved addresses.
The reset button and manual entry options should still function as expected.

How can we measure success?

Have we considered potential risks?

If AJAX fails, the dropdown might not populate, but this is handled by adding a fallback message ("No addresses found").

Images

Accessibility

• Tested with screen reader
• Navigable with keyboard
• Colour contrast passed
• The change doesn't use only colour to convey meaning

[ekes]

That should probably have got reviewed before merging :-)

@Adnan-cds you still want to look it over?

[Adnan-cds]

I will try to have a look within the next day or so.

[andybroomfield]

Tested with the BHCC geocoder, not seen any issues, but I'm also uncertain what this is changing so I don't know what to check for.

[Adnan-cds]

Hello,
Thanks for providing this fix. I have had a look now. This change is attempting to fix a long standing issue with the localgov_base theme. I would request that you revert this change and try to fix localgov_base.

While this fix works for one Address lookup element, it breaks when there are more than one :(

[Adnan-cds]

Ah, thanks for checking Andy. This issue with localgov_base is becoming a real nuisance.

[andybroomfield]

I was going to say this has started to work with localgov_scarfolk with this fix.

[andybroomfield]

Confirming this is now broken when there are two address lookups on a page.

[PardeepSinghBali]

Confirming this is now broken when there are two address lookups on a page.

thanks for confirming, this issue will be resolved in next commit