-
Notifications
You must be signed in to change notification settings - Fork 2
adds feedback form #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: @ekes mentioned we want to check what we did to prevent session cookie getting set. |
|
Discussing at Merge Tuesday - @ekes to double check if there's seesion cookies getting set |
|
No session cookie being set. Not even on submission. It sets the cache control header to no-cache on a submission return page. So with cache time in core enabled the page would be like There is also no spam control though ;-) Other non-related concern would be putting something about personal information somewhere, not to be encouraging councils to end up with personal info in the db. |
|
@andybroomfield mentions the need for a council to get a DPA (approval from the legal department) before deploying this a form. @ekes highlights the need to encourage users to NOT submit personal data. Also - we might be able to include default options to make use of the long term storage and purge results. |
|
Discussing at Merge Tuesday - perhaps just show a message when enabling the module with a little more detail in the README. |
Done, and done. |
ekes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per comment, cookies checked, ok.
Added notification at install and readme over dpa.
Can double check opinions at MT, but think this has covered all concerns.
Closes #91
What does this change?
Adds a new form for a simple feedback widget.
How to test
localgov_forms_feedback_formmoduleThanks to Big Blue Door for sponsoring my time to work on this.