Skip to content

Fix TUnit assertion patterns and optimize JsonObject access #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix TUnit assertion patterns and optimize JsonObject access #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d014d3
Initial plan
Copilot Dec 18, 2025
59d13e4
fix: address PR review feedback for TUnit assertions and code quality
Copilot Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...pire.Hosting.LocalStack.Integration.Tests/EagerLoadedServices/EagerLoadedServicesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,10 @@ public async Task LocalStack_Should_Handle_Empty_EagerLoadedServices_Like_Lazy_L
await Assert.That(servicesNode).IsNotNull();

// Services should not be running by default (lazy loading)
if (servicesNode.ContainsKey("sqs"))
var sqsService = servicesNode["sqs"];
if (sqsService is not null)
{
await Assert.That(servicesNode["sqs"]?.ToString()).IsNotEqualTo("running");
await Assert.That(sqsService.ToString()).IsNotEqualTo("running");
}
}

Expand Down
15 changes: 8 additions & 7 deletions tests/Aspire.Hosting.LocalStack.Unit.Tests/Extensions/LocalStackProjectExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,19 @@ public async Task WithReference_Should_Return_Builder_When_LocalStack_Is_Null()
{
const string testProjectResourceName = "test-project";

IResourceBuilder<ProjectResource>? resultBuilder = null;
IResourceBuilder<ProjectResource>? originalBuilder = null;

var (app, projectResource) = TestApplicationBuilder.CreateWithResource<ProjectResource>(testProjectResourceName, builder =>
{
var projectBuilder = builder.AddProject(testProjectResourceName, TestDataBuilders.GetTestProjectPath());
var result = projectBuilder.WithReference(localStackBuilder: null);

// Should return the same builder
if (!ReferenceEquals(result, projectBuilder))
{
throw new InvalidOperationException("Builder should be the same reference");
}
originalBuilder = projectBuilder;
resultBuilder = projectBuilder.WithReference(localStackBuilder: null);
});

// Should return the same builder instance
await Assert.That(resultBuilder).IsSameReferenceAs(originalBuilder);

await Assert.That(app.HasResource<ILocalStackResource>("localstack")).IsFalse();
await projectResource.ShouldNotHaveLocalStackEnabledAnnotation();
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Aspire.Hosting.LocalStack.Unit.Tests/TestUtilities/LocalStackAssertions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static async Task ShouldHaveLocalStackEnvironmentConfiguration(this Proje
{
ArgumentNullException.ThrowIfNull(projectResource);
ArgumentNullException.ThrowIfNull(expectedLocalStack);
#pragma warning disable MA0015
#pragma warning disable MA0015 // ArgumentNullException.ThrowIfNull should be preferred over null check
ArgumentNullException.ThrowIfNull(expectedLocalStack.Options);
#pragma warning restore MA0015

Expand Down