Skip to content

chore: run dns check upon reconfiguring aws-profile #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiurin merged 1 commit into from
Sep 10, 2025
Merged

chore: run dns check upon reconfiguring aws-profile #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/utils/configure-aws.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,23 @@ function isValidEndpointUrl(url: string | undefined): boolean {
}
}

function checkIfConfigNeedsOverride(section: IniSection | undefined): boolean {
async function checkIfConfigNeedsOverride(
section: IniSection | undefined,
): Promise<boolean> {
if (!section) {
return true; // profile doesn't exist
}

if (
section.properties.endpoint_url === "http://localhost.localstack.cloud:4566"
) {
const isDnsResolved = await dnsResolveCheck(undefined);
if (!isDnsResolved) {
// if DNS is not resolved, we need to override the endpoint_url
return true;
}
}

return !(
section.properties.region &&
section.properties.endpoint_url &&
Expand Down Expand Up @@ -317,7 +329,7 @@ export async function configureAwsProfiles(options: {
let configModified: boolean | undefined;
let credentialsModified: boolean | undefined;

const configNeedsOverride = checkIfConfigNeedsOverride(configSection);
const configNeedsOverride = await checkIfConfigNeedsOverride(configSection);
const credentialsNeedsOverride =
checkIfCredentialsNeedsOverride(credentialsSection);

Expand Down
Loading