Update to Python3 and minor updates#6
Open
paulboot wants to merge 7 commits intolocationlabs:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Vince,
I needed a nagios plugin to monitor some values in influx so I played around with 'influxdb-nagios-plugin'. I updated the code to Python3 and tested on Python3.5.2. I think it is OK. Tweaked the documentation and added two examples to the README.
However I could not get the tests running, Pytest throws an error, I do not why because hamcrest is installed in my env.
Could you review my PR and do a suggestion how to fix
pytest.With kind regards,
Paul Boot.