Fix issues #130 and #131: Support Lua in Python 3 and improve mock signatures#133
Open
beamerblvd wants to merge 1 commit intolocationlabs:masterfrom
Open
Fix issues #130 and #131: Support Lua in Python 3 and improve mock signatures#133beamerblvd wants to merge 1 commit intolocationlabs:masterfrom
beamerblvd wants to merge 1 commit intolocationlabs:masterfrom
Conversation
This was referenced Oct 31, 2017
54f4f99 to
c793b89
Compare
e8d2864 to
ee65860
Compare
Author
|
Would love to get a review of this. Currently monkey-patching it in our project, but would prefer to use it unpatched. :-) |
ushuz
reviewed
Sep 20, 2018
|
|
||
| LuaLock = threading.Lock() | ||
|
|
||
| if sys.version_info[0] == 3: |
There was a problem hiding this comment.
Python 2 should be the special case here. In future, when Python 4 gets released, this if will fallback to the logics for Python 2, which will definitely be incompatible with Python 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redis.status_replyandredis.error_replyin Lua scriptsfrom_urland Mock-specific kwargs