set gdal roles for well known tags#3570
Conversation
|
Ready for review, I found more tags that require the role attribute by looking at GDAL source itself: We'd appreciate getting this merged, because we found out that fixing the tiff header afterwards breaks COG compatibility. |
|
@jdries I'll take a look shortly and cut a release for you; there is also a tiny Proj4J release https://github.com/locationtech/proj4j/releases/tag/v1.4.0 that we'd needto include 👍 Thanks for making a PR! |
|
Also if you could take a look into the failing CI it would def help to get it merged faster! |
|
CI ok! |
pomadchin
left a comment
There was a problem hiding this comment.
Thanks 👍 I'll hopefully have time to review the rest of the PRs so we can get them merged before cutting a release.
#3496
Overview
Certain tags in GDAL are standardized, but this requires a 'role' attribute to be set.
In this PR, I take the approach of simply having a static list of such 'well-known' tags that seem to be part of the GDAL standard.
Checklist
docsguides update, if necessaryNotes
Caveat: if gdal invents new roles, we need to update the list.
Closes #3496