Skip to content

Conversation

@MSementsov-Ibk
Copy link
Contributor

...and there was no run

Signed-off-by: Michael Sementsov [email protected]

@fgdrf
Copy link
Contributor

fgdrf commented Oct 23, 2018

Ate the moment I do not understand how the description of this changeset is related to modified lines. Change indicates that is a safer implemantation which checks for null first before removing listeners.

Is it possible the not all changes were added to the commit?

@MSementsov-Ibk
Copy link
Contributor Author

Sorry for the wonky description, what I meant is:

If setGraphics (AbstractDrawCommand.setGraphics(), in the superclass to MessageBubble) was never called, then a display was never registered and therefore there are also no Listeneres for setValid to remove.

It's a change from a while ago, so I can't say where I encountered this calling order, I'll post it here when I find it again.

Copy link
Contributor

@fgdrf fgdrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a chance that display isn't set yet, run method should implement a safe-check as well.

I'll have a look at and provide a pull to contribute to your change, stay tuned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants