Merged
Conversation
kaplanelad
changed the title
Contributor
Author
|
Hey @NexVeridian, Thanks! |
NexVeridian
approved these changes
Apr 24, 2025
Contributor
NexVeridian
left a comment
NexVeridian
left a comment
There was a problem hiding this comment.
Look good!
I'll fix the review spots in another pr
This can me merged now!
Comment on lines
+126
to
+127
| paths(album::get_album), // Add album path to OpenAPI spec | ||
| components(schemas(album::Album)), // Add album schema |
Contributor
There was a problem hiding this comment.
Suggested change
| paths(album::get_album), // Add album path to OpenAPI spec | |
| components(schemas(album::Album)), // Add album schema |
Album schema already collected, so this doesn't do anything
| pub fn routes() -> Routes { | ||
| Routes::new() | ||
| .prefix("api/album") | ||
| .add("/get_album", openapi(get(get_album), routes!(get_album))) |
Contributor
There was a problem hiding this comment.
Album schema collected here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b77596e: refactor and tests for auth.rs
c7438d8: refactor and tests config.rs + refactor lib.rs