Make possible to set a custom template for a new project#1689
Closed
ofabianomartins wants to merge 14 commits intoloco-rs:masterfrom
Closed
Make possible to set a custom template for a new project#1689ofabianomartins wants to merge 14 commits intoloco-rs:masterfrom
ofabianomartins wants to merge 14 commits intoloco-rs:masterfrom
Conversation
a0f6443 to
17e02e3
Compare
f4aab77 to
fb4b530
Compare
Contributor
|
Thanks for the contribution! A few things:
|
Contributor
Author
|
Thanks for feedback, i will work on it. |
Contributor
Author
|
@kaplanelad i made update you asked. Could review please. |
Contributor
|
Hey @ofabianomartins, thanks for the effort on this! Unfortunately I'm going to pass on merging this PR. The feature introduces git cloning, zip downloading, and HTTP fetching into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enable
loco newcommand use a custom start template by setting a new option--template-dirthe direct to especif folder