Fix use log_message instead of echo #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the script to use the centralized log_message function for error output and bumps the version.
- Bumped
SCRIPT_VERSIONfrom 0.0.3 to 0.0.4 - Replaced direct
echocalls for errors withlog_message ... >&2
Comments suppressed due to low confidence (3)
sync-ssh-keys.sh:4
- Consider updating any related documentation or changelog entries that reference the script version to align with this bump.
SCRIPT_VERSION="0.0.4"
sync-ssh-keys.sh:9
- Add or update automated tests (or integration tests) to cover this failure path when the configuration file is missing, ensuring the error is logged and the script exits correctly.
log_message "Error: Configuration file 'users.conf' not found in $SCRIPT_DIR. Halting execution." >&2
sync-ssh-keys.sh:13
- [nitpick] To reduce repeated patterns of logging and exiting, consider introducing an
exit_with_errorhelper that callslog_messageand exits, centralizing error handling.
log_message "Error: Failed to load configuration file 'users.conf'. Please check the file for syntax errors. Halting execution." >&2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.