-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add method for using keys from github profile #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new ghuser method to fetch public SSH keys directly from a GitHub user’s profile, updates the configuration example, bumps the script version, and documents the change.
- Add
ghuserfetch method insync-ssh-keys.sh - Update
users.confexample to useghuser - Bump script version and expand README with new method
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| users.conf | Replaced admin entry with alice using ghuser |
| sync-ssh-keys.sh | Bumped version; renamed $URL to $TARGET; added ghuser branch with custom error handling |
| README.md | Documented the new ghuser method and updated usage |
Comments suppressed due to low confidence (2)
sync-ssh-keys.sh:47
- [nitpick] The error message still refers to 'URL' even when the
$TARGETmay be a GitHub username. Consider changing the wording to 'target' or 'resource' to avoid confusion.
log_message "Error: Unsupported method '$METHOD' encountered for URL '$TARGET'. Halting execution."
sync-ssh-keys.sh:38
- The new
ghuserbranch isn't covered by any tests. Adding unit or integration tests to simulate successful and failed key fetches for this method would help ensure future reliability.
elif [[ "$METHOD" == "ghuser" ]]; then
No description provided.