Skip to content

Bump pip version #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump pip version #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68906a9
BUmp pip version
paulbovbel Apr 5, 2024
1c9da33
Remove old unused version check that depends on a binary named python…
meyerj Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions catkin_virtualenv/src/catkin_virtualenv/venv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ def initialize(self, python, use_system_packages, extra_pip_args, clean=True):
raise RuntimeError(error_msg)

preinstall = [
"pip==22.2.2",
"pip-tools==6.10.0",
"pip==23.3.2",
"pip-tools==7.4.1",
]

builtin_venv = self._check_module(system_python, "venv")
Expand All @@ -90,14 +90,6 @@ def initialize(self, python, use_system_packages, extra_pip_args, clean=True):
run_command(virtualenv, check=True)

if without_pip:
# install pip via get-pip.py
version_proc = run_command(
["python", "-cimport sys; print('{}.{}'.format(*sys.version_info))"], capture_output=True
)
version = version_proc.stdout
if isinstance(version, bytes):
version = version.decode("utf-8")
version = version.strip()
# download pip from https://bootstrap.pypa.io/pip/
get_pip_path, _ = urlretrieve("https://bootstrap.pypa.io/pip/get-pip.py")
run_command([self._venv_bin("python"), get_pip_path], check=True)
Expand Down