Skip to content

Use CXX_STANDARD 20 in all packages #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Use CXX_STANDARD 20 in all packages #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a350ec0
Use CXX_STANDARD 20 in all packages
efernandez Apr 16, 2025
c4343a1
Fix maybe-uninitialized
efernandez Apr 16, 2025
bceb71f
Use CXX_STANDARD 17 for fuse_viz
efernandez Apr 16, 2025
c020373
Disambiguate GradientChecker overloaded ctor call
efernandez Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions fuse_constraints/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ target_link_libraries(${PROJECT_NAME}
)
set_target_properties(${PROJECT_NAME}
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand Down Expand Up @@ -188,7 +188,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_absolute_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -214,7 +214,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_absolute_orientation_2d_stamped_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -240,7 +240,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_absolute_orientation_3d_stamped_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -266,7 +266,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_absolute_orientation_3d_stamped_euler_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -290,7 +290,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_absolute_pose_2d_stamped_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -314,7 +314,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_fixed_3d_landmark_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -338,7 +338,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_absolute_pose_3d_stamped_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -361,7 +361,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_marginal_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -384,7 +384,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_marginalize_variables
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -408,7 +408,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_normal_delta_pose_2d
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -432,7 +432,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_normal_prior_pose_2d
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -456,7 +456,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_relative_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -480,7 +480,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_relative_pose_2d_stamped_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -504,7 +504,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_relative_pose_3d_stamped_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -523,7 +523,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_uuid_ordering
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -540,7 +540,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_variable_constraints
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -562,7 +562,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(benchmark_normal_delta_pose_2d
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)
endif()
Expand All @@ -581,7 +581,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(benchmark_normal_prior_pose_2d
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)
endif()
Expand Down
36 changes: 18 additions & 18 deletions fuse_core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ target_link_libraries(${PROJECT_NAME}
)
set_target_properties(${PROJECT_NAME}
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -110,7 +110,7 @@ target_link_libraries(fuse_echo
)
set_target_properties(fuse_echo
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand Down Expand Up @@ -171,7 +171,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_async_motion_model
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -197,7 +197,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_async_publisher
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -223,7 +223,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_async_sensor_model
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -248,7 +248,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_callback_wrapper
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -273,7 +273,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_constraint
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -298,7 +298,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_eigen
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -315,7 +315,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_local_parameterization
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -340,7 +340,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_loss
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -364,7 +364,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_message_buffer
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -389,7 +389,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_timestamp_manager
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -415,7 +415,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_transaction
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -440,7 +440,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_parameter
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -462,7 +462,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_throttled_callback
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -486,7 +486,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_util
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -511,7 +511,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_uuid
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -537,7 +537,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_variable
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)
endif()
2 changes: 1 addition & 1 deletion fuse_core/test/test_variable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ TEST(LegacyVariable, Deserialization)
EXPECT_EQ(expected.data()[3], actual.data()[3]);

// Test the manifold interface, and that the Legacy LocalParameterization is wrapped in a ManifoldAdapter
fuse_core::Manifold* actual_manifold;
fuse_core::Manifold* actual_manifold = nullptr;
ASSERT_NO_THROW(actual_manifold = actual.manifold());
ASSERT_NE(actual_manifold, nullptr);
auto actual_manifold_adapter = dynamic_cast<fuse_core::ManifoldAdapter*>(actual_manifold);
Expand Down
6 changes: 3 additions & 3 deletions fuse_graphs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ target_link_libraries(${PROJECT_NAME}
)
set_target_properties(${PROJECT_NAME}
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand Down Expand Up @@ -136,7 +136,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(test_hash_graph
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)

Expand All @@ -162,7 +162,7 @@ if(CATKIN_ENABLE_TESTING)
)
set_target_properties(benchmark_create_problem
PROPERTIES
CXX_STANDARD 17
CXX_STANDARD 20
CXX_STANDARD_REQUIRED YES
)
endif()
Expand Down
Loading