feat: add native cascade dismiss api #452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@obi-owner is attempting to deploy a commit to the Jovanni's projects Team on Vercel. A member of the Team first needs to authorize it. |
9 tasks
lodev09
requested changes
Jan 20, 2026
Owner
lodev09
left a comment
lodev09
left a comment
There was a problem hiding this comment.
Looks good so far. Just need to retain the dismiss name on the native instead of the old dismissAll. This should make methods consistent in the native too. Just add code comment so it's clear.
Comment on lines
+391
to
+401
| dismiss: async () => { | ||
| const sheetsAbove = bottomSheetContext?.getSheetsAbove(sheetName) ?? []; | ||
|
|
||
| // Dismiss all sheets above sequentially since gorhom/bottom-sheet doesn't support cascade dismiss | ||
| for (const sheet of sheetsAbove) { | ||
| await bottomSheetContext?.dismissDirect(sheet); | ||
| } | ||
|
|
||
| // Then dismiss this sheet | ||
| await dismissInternal(); | ||
| }, |
Owner
There was a problem hiding this comment.
Can you try calling dismissChildren here first before itself?
Owner
|
Also, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dismiss()is calleddismissChildren()method to only dismiss the children presented on top of the current sheetThis must be merged before #444
Type of Change
Test Plan
Screenshots / Videos
Checklist