Fix (de)serialization of an index containing unicode surrogate characters#7
Merged
lofcz merged 1 commit intolofcz:masterfrom Dec 2, 2025
Merged
Fix (de)serialization of an index containing unicode surrogate characters#7lofcz merged 1 commit intolofcz:masterfrom
lofcz merged 1 commit intolofcz:masterfrom
Conversation
Owner
|
Good catch! |
lofcz
approved these changes
Dec 2, 2025
lofcz
added a commit
that referenced
this pull request
Dec 30, 2025
Fix (de)serialization of an index containing unicode surrogate characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
SearchEngine.Saveleads to an exception if unicode surrogate characters are present in the index.This PR fixes the serialization by writing and reading the char as uint16.