restore vCluster config from snapshot #3340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neogopher
force-pushed
the
snapshot-restore-vcluster-config
branch
2 times, most recently
from
0d06495 to
40ba2e6
Compare
neogopher
force-pushed
the
snapshot-restore-vcluster-config
branch
from
40ba2e6 to
4d888da
Compare
Member
|
@claude Please review this PR and suggest improvements |
Member
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-9486
Please provide a short message that should be published in the vcluster release notes
vCluster will now automatically restore the cluster.yaml configuration while restoring from a snapshot
What else do we need to know?
Note
Load Helm release values from snapshot, merge with defaults, use for restore/config parsing, and write to
vc-config-*Secret; CLI consumes snapshot values/versions during--restore.snapshot.GetVClusterReleaseFromSnapshotto extractHelmReleasefrom snapshot.mergeWithDefaults) and parse config viaconfig.ParseConfigBytes.InitClients) and use merged config for restore validation.Secretvc-config-<name>(config.yaml).createRestoreRequestto use internalo.vConfig.pkg/cli/create_helm.go):snapshot.GetVClusterReleaseFromSnapshotto fetch config on--restore.cmd.ChartVersionfrom snapshot release and temp-write values for install/upgrade.Written by Cursor Bugbot for commit 4d888da. This will update automatically on new commits. Configure here.