Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/platform/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
)

var (
MinimumVersionTag = "v4.5.0"
MinimumVersionTag = "v4.5.1"
MinimumVersion = semver.MustParse(strings.TrimPrefix(MinimumVersionTag, "v"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional enhancement: Consider adding a compile-time validation test to ensure MinimumVersionTag is always a valid semver string. This would catch any future manual edits that might introduce invalid versions.

Example test:

func TestMinimumVersionTagIsValid(t *testing.T) {
    _, err := semver.Parse(strings.TrimPrefix(MinimumVersionTag, "v"))
    if err != nil {
        t.Fatalf("MinimumVersionTag %q is not a valid semver: %v", MinimumVersionTag, err)
    }
}

This is not blocking for this PR, just a suggestion for future robustness.

)

Expand Down
Loading