Skip to content

Conversation

@hidalgopl
Copy link
Contributor

@hidalgopl hidalgopl commented Nov 14, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-8077

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster cert rotate was failing for vCluster Standalone

What else do we need to know?
Command was failing because we try to read namespace from the serviceaccount namespace file which doesn't exist for standalone. And the namespace isn't required for standalone certs, so we can set it to default.


Note

Sets NAMESPACE=default during standalone cert rotation to prevent failures when namespace is absent.

  • Cert Rotation (standalone):
    • In cmd/vcluster/cmd/certs/rotate.go, after parsing standalone config, sets env var NAMESPACE to default if unset, with debug log on failure.
    • No changes to non-standalone path; continues using config.ParseConfig and existing rotation flow.

Written by Cursor Bugbot for commit 4308a68. This will update automatically on new commits. Configure here.

Signed-off-by: Paweł Bojanowski <[email protected]>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link
Contributor

@johannesfrey johannesfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants