fix: fix pods/resize verbs in chart role templates#3544
fix: fix pods/resize verbs in chart role templates#3544FabianKramm merged 1 commit intoloft-sh:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 216dac08ed
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
chart/templates/role.yaml
Outdated
| - apiGroups: [""] | ||
| resources: ["pods/resize"] | ||
| verbs: ["patch"] |
There was a problem hiding this comment.
The rule for pods/resize now grants only patch, but Kubernetes’ generated client uses UpdateResize with verb update on the resize subresource (see vendor/k8s.io/api/core/v1/types.go around the +genclient:method=UpdateResize,verb=update,subresource=resize annotation). In clusters where this rule applies (>=1.35 per the Helm gate), any controller or client-go caller using the standard update path will still receive RBAC 403s, so resize operations remain broken. Consider including update (and optionally patch) in the verbs list.
Useful? React with 👍 / 👎.
flomedja
force-pushed
the
fix-pod-resize-role-in-chart
branch
from
216dac0 to
493b329
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
3 participants
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?