Skip to content

Docker: run modprobe only when overlay/bridge/br_netfilter are not lo… #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabianKramm merged 1 commit into from
Feb 6, 2026
Merged

Docker: run modprobe only when overlay/bridge/br_netfilter are not lo… #3562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions pkg/cli/create_docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,30 @@ func CreateDocker(ctx context.Context, options *CreateOptions, globalFlags *flag
return fmt.Errorf("failed to load docker config: %w", err)
}

// On Linux, load kernel modules required for node join (bridge, br_netfilter, overlay).
// Only run modprobe for modules not already loaded (check via /proc/modules, no sudo).
if runtime.GOOS == "linux" {
required := []string{"overlay", "bridge", "br_netfilter"}
loaded := make(map[string]bool)
if data, err := os.ReadFile("/proc/modules"); err == nil {
scanner := bufio.NewScanner(strings.NewReader(string(data)))
for scanner.Scan() {
fields := strings.Fields(scanner.Text())
if len(fields) > 0 {
loaded[fields[0]] = true
}
}
}
for _, mod := range required {
if loaded[mod] {
continue
}
if err := exec.CommandContext(ctx, "modprobe", mod).Run(); err != nil {
log.Warnf("Could not load kernel module %s: %v. If node join fails, run: sudo modprobe overlay && sudo modprobe bridge && sudo modprobe br_netfilter", mod, err)
}
}
}

// configure the network and update user values if needed
networkName, extraDockerArgs, err := configureNetwork(ctx, userValuesRaw, vClusterName, log)
if err != nil {
Expand Down
Loading