fix: Github Copilot add streaming support and improve robustness #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add streaming response with SSE parsing (eventsource-parser) - Add Accept: text/event-stream header and content-type validation - Add empty output detection to prevent silent failures - Unify token expiry logic between getAuthState() and getValidCopilotToken() - Add proper resource cleanup with reader.cancel() - Add request cancellation handling in GitHubCopilotAuth component - Extract HTTP_STATUS_MESSAGES constant - Remove fallback mechanism for simpler error handling
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds streaming response support for GitHub Copilot integration and improves overall robustness of the provider.
Changes
Streaming Support
eventsource-parserAccept: text/event-streamheader and content-type validation_streamResponseChunksmethod inGitHubCopilotChatModelRobustness Improvements
getAuthState()andgetValidCopilotToken()reader.cancel()GitHubCopilotAuthcomponentHTTP_STATUS_MESSAGESconstant for better error messagesSimplification
Files Changed
src/LLMProviders/githubCopilot/GitHubCopilotChatModel.ts- Add streaming supportsrc/LLMProviders/githubCopilot/GitHubCopilotProvider.ts- Improve token handling and SSE parsingsrc/settings/v2/components/GitHubCopilotAuth.tsx- Add request cancellation handling