suppressing by id #47
Conversation
|
cc @frakman1 |
# Conflicts: # poetry.lock
|
@angrymeir can I ask you for fast code review and merge and release for @frakman1 :) |
|
@angrymeir friendly reminder |
|
@marwin1991 Thank you so much for the implementation! Looks good to me :) I'll do one final test run tonight and then we're ready to go 🚀 |
secscanner2junit/config.py
Outdated
|
|
||
| class Suppression: | ||
| def __init__(self, type, value): | ||
| def __init__(self, id, type, value): |
There was a problem hiding this comment.
I'd suggest we make the parameters optional (def __init__(self, id=None, type=None, value=None)) here, since either id or type and value will be empty. And otherwise the old configuration will assign the type to id and the value to type leaving value empty.
There was a problem hiding this comment.
Please let me know if that makes sense to you :)
Btw fyi: In the next days I'll integrate the unit tests into our CI, so we can automatically see if there's any issues
There was a problem hiding this comment.
I guess in addition we'll have to adjust
expected = Config([Suppression('cwe', '2555'), Suppression('find_sec_bugs_type', 'SPRING_ENDPOINT')])
to
expected = Config([Suppression(None, 'cwe', '2555'), Suppression(None, 'find_sec_bugs_type', 'SPRING_ENDPOINT')])
in /tests/test_config.py
angrymeir
left a comment
angrymeir
left a comment
There was a problem hiding this comment.
Thank you so much @marwin1991!
I'll push the new release once you merged it :)
|
@angrymeir let's go 🚀 🌔 |
Implement: #19 (comment)