Skip to content

Conversation

@kennethmhc
Copy link
Contributor

No description provided.

Copy link
Contributor

@aversey aversey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are to be made. Overall, I don't think the structure of "a bunch of examples" works well here. There is clearly a single main example and then a bit of information on how to update a TTL value of an existing FG. The main example itself is also too abstract to be relatable; it is better to use a concrete, simple FG instead. I would also try to summarize the goal of TTL usage in the example (to save resources or to simplify the usage of the FG) and state that it is achieved by following the guide/example. A user guide should show a user exactly how to achieve something useful for them; for easier searching, the useful effect of the guide should be stated explicitly.

Copy link
Contributor Author

@kennethmhc kennethmhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original intend is to create example for TTL as requested by Ray. But I can extend it to include the use cases.

@kennethmhc kennethmhc requested a review from aversey January 8, 2026 09:02
@kennethmhc kennethmhc merged commit 4106328 into logicalclocks:main Jan 8, 2026
1 check passed
kennethmhc added a commit to kennethmhc/logicalclocks.github.io that referenced this pull request Jan 8, 2026
* add ttl example

* update doc

* fix style

* separate line

* indent code block

---------

Co-authored-by: Aleksey Veresov <[email protected]>
kennethmhc added a commit that referenced this pull request Jan 8, 2026
* Add ttl example (#533)

* add ttl example

* update doc

* fix style

* separate line

* indent code block

---------

Co-authored-by: Aleksey Veresov <[email protected]>

* fix link

* fix mkdocs test

---------

Co-authored-by: Aleksey Veresov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants