Abstract over subscriber registration to ease setup. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR reorganizes import statements across the codebase to follow a consistent alphabetical ordering. Test files and source files have been updated to place third-party imports before local imports, with alphabetical sorting within each group. Additionally, the PR includes type safety improvements in several source files, including adding explicit type annotations and using the new pyrefly type checker instead of pyright.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/logicblocks/event/store/test_store.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/store/adapters/memory/test_adapter.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/projection/store/test_store.py | Reordered imports and added missing metadata_type parameter to load() calls |
| tests/unit/logicblocks/event/projection/store/adapters/test_memory.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/services/test_error.py | Updated error handler constructors and type mappings for API changes |
| tests/unit/logicblocks/event/processing/locks/test_memory.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/consumers/test_subscription.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/consumers/source/test_source_managed_event_processor.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/consumers/source/test_source_event_processor.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/consumers/source/test_source_auto_commit_event_processor.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/brokers/subscribers/stores/instances/test_memory.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/brokers/strategies/singleton/test_broker.py | Reordered imports, added type hints for broker params dicts |
| tests/unit/logicblocks/event/processing/brokers/strategies/distributed/test_observer.py | Reordered imports, added type hints for observer params dict |
| tests/unit/logicblocks/event/processing/brokers/strategies/distributed/test_coordinator.py | Reordered imports, added type hints for coordinator params dict |
| tests/unit/logicblocks/event/processing/brokers/strategies/distributed/test_broker.py | Reordered imports, added explicit type annotations in mock classes |
| tests/unit/logicblocks/event/processing/brokers/strategies/distributed/subscriptions/stores/state/test_memory.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/brokers/strategies/distributed/subscribers/test_manager.py | Reordered imports to place third-party before local imports |
| tests/unit/logicblocks/event/processing/brokers/strategies/distributed/subscribers/stores/state/test_memory.py | Reordered imports to place third-party before local imports |
| tests/shared/logicblocks/event/testcases/processing/broker/strategies/distributed/subscribers/stores/state.py | Reordered imports to place third-party before local imports |
| tests/integration/logicblocks/event/store/adapters/test_postgres.py | Reordered imports to place third-party before local imports |
| tests/integration/logicblocks/event/projection/store/adapters/test_postgres.py | Reordered imports to place third-party before local imports |
| tests/integration/logicblocks/event/processing/locks/test_postgres.py | Reordered imports to place third-party before local imports |
| tests/integration/logicblocks/event/processing/broker/strategies/distributed/test_broker.py | Reordered imports to place third-party before local imports |
| tests/integration/logicblocks/event/processing/broker/strategies/distributed/subscriptions/stores/state/test_postgres.py | Reordered imports to place third-party before local imports |
| tests/integration/logicblocks/event/processing/broker/strategies/distributed/subscribers/stores/state/test_postgres.py | Reordered imports to place third-party before local imports |
| tests/component/test_processing.py | Reordered imports to place third-party before local imports |
| tests/component/test_asynchronous_projections.py | Reordered imports to place third-party before local imports |
| tasks/types.py | Changed type check command from pyright to pyrefly |
| src/logicblocks/event/types/identifier.py | Added explicit type casts for string conversion |
| src/logicblocks/event/types/conversion.py | Added type casts to fix type checking errors |
| src/logicblocks/event/testing/builders.py | Extracted kwargs to local variables in _clone methods |
| src/logicblocks/event/store/conditions.py | Added proper __eq__ and __hash__ implementations to all WriteCondition subclasses |
| src/logicblocks/event/store/adapters/postgres/adapter.py | Added type casts and extracted variables for better type safety |
| src/logicblocks/event/store/adapters/memory/adapter.py | Added generic type parameters to _determine_required_locks method |
| src/logicblocks/event/sources/memory.py | Removed pyright ignore comments |
| src/logicblocks/event/projection/store/store.py | Removed default values from state_type and metadata_type parameters |
| src/logicblocks/event/processing/services/manager.py | Added ServiceExecutor ABC and explicit type annotations |
| src/logicblocks/event/processing/services/error.py | Major refactoring of error handling API with type safety improvements |
| src/logicblocks/event/processing/services/init.py | Updated exports for new error handler type mapping functions |
| src/logicblocks/event/processing/consumers/subscription.py | Added make_event_store_subscriber and removed default from make_subscriber |
| src/logicblocks/event/processing/broker/strategies/singleton/factories.py | Added default value for adapter parameter |
| src/logicblocks/event/processing/init.py | Updated exports for new error handler type mapping functions |
| src/logicblocks/event/persistence/postgres/query.py | Added LiteralString casts for SQL direction values |
| src/logicblocks/event/persistence/converter.py | Added explicit type annotation for registry field |
| pyproject.toml | Replaced pyright with pyrefly, updated dependencies versions |
| mise.toml | Updated tool versions and task configurations |
| meta/templates/pr-description.md | Added new PR description template |
| meta/research/2025-12-02-event-processing-node-abstraction.md | Added research document on event processing infrastructure |
| meta/prs/85-description.md | Added PR description document |
| meta/plans/2025-12-02-event-runtime-abstraction.md | Added implementation plan for EventRuntime abstraction |
| meta/examples/subscriber_registration/subsytem_creator.py | Added example of subsystem creator pattern |
| meta/examples/subscriber_registration/register_one_function.py | Added example of single function registration pattern |
| meta/examples/subscriber_registration/register_many_function.py | Added example of batch registration pattern |
| meta/examples/subscriber_registration/consumer_registrar.py | Added example of consumer registrar pattern |
| meta/examples/subscriber_registration/all_in_one_function.py | Added example of all-in-one function pattern |
| changelog.d/20251201_190227_ci_switch_to_pyrefly.md | Added changelog fragment documenting breaking changes |
| README.md | Simplified development section with reference to CONTRIBUTING.md |
| CONTRIBUTING.md | Added comprehensive contributing guidelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.