adding count method to projection store #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a count method to projection store adapters to return the total number of projections, implementing the method in both in-memory and Postgres adapters and adding comprehensive test coverage.
Changes:
- Added abstract
countmethod to the base adapter interface - Implemented
countin both in-memory and Postgres adapters - Added
CountCasestest class with scenarios covering empty state, single/multiple projections, and updates
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/logicblocks/event/projection/store/adapters/base.py | Added abstract count method to base adapter interface |
| src/logicblocks/event/projection/store/adapters/memory.py | Implemented count method returning length of projections list |
| src/logicblocks/event/projection/store/adapters/postgres.py | Implemented count method using SQL COUNT query |
| tests/shared/logicblocks/event/testcases/projection/store/adapters.py | Added CountCases test class with comprehensive count scenarios and integrated into main test case mixin |
mhmsvv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new method to count the number of projections in projection store adapters and provides comprehensive tests to ensure its correctness across implementations. The main changes include adding the abstract
countmethod to the base adapter, implementing it in both the in-memory and Postgres adapters, and expanding the shared test suite to cover various counting scenarios.Projection Store Adapter Enhancements
countmethod to the base adapter interface inbase.py, requiring all projection store adapters to implement a method that returns the number of projections.countmethod in the in-memory adapter (memory.py), returning the length of the internal projections list.countmethod in the Postgres adapter (postgres.py), executing a SQL query to count the rows in the projections table.Testing Improvements
CountCasestest class to the shared adapter test suite (adapters.py), covering scenarios such as zero projections, single and multiple projections, and updating existing projections. Integrated these tests into the main test case mixin.