Sfp and Link status work #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes handling of the SFP ports in the stat command. The output of the command now is for physical ports, which however are not shown in sequence.
The RTL8272/3 use 2 32 bit registers to indicate the MAC link speed, the second register is used for ports 8 and 9, where 9 is the CPU port. Use both registers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several issues with the existing SFP code and the link status code. It now provides full support for 2 SFP ports and uses also the link status register for ports 8 and 9 correctly.
This was tested on 5+1, 4+2 and 8+1 devices.
An example output now is e.g.:
For reasons of code complexity (use of additional variables), the ports are not in sequence on RTL8272 devices, only for RTL8273 this is the case.