fix: use main field in manifest/metadata json files to determine available plugins#99
Merged
Khushboo-dev-cpp merged 1 commit intomasterfrom Mar 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates UI plugin discovery/loading to correctly handle both dev plugins (with metadata.json) and LGX-installed plugins (with manifest.json), and to use the manifest/metadata "main" field when determining the C++ plugin library filename.
Changes:
- Update
readPluginManifest()andgetPluginType()to fall back frommanifest.jsontometadata.json. - Add helpers to resolve
"main"across string vs platform-keyed-object formats and use that resolved name for C++ plugin discovery and loading paths. - Bump the
logos-liblogosinput inflake.lock.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/MainUIBackend.cpp | Adds manifest/metadata fallback, resolves "main" for correct shared-library discovery/loading, and introduces platform-variant helpers. |
| flake.lock | Updates the pinned revision/hash/timestamp for a Nix input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Khushboo-dev-cpp
force-pushed
the
fix/useMainToDeterminePluginPaths
branch
from
d9f19f1 to
dabb82d
Compare
Khushboo-dev-cpp
force-pushed
the
fix/useMainToDeterminePluginPaths
branch
from
dabb82d to
1185200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously assumed the .dylib filename matched the subdirectory name (e.g. calc_ui_cpp/calc_ui_cpp.dylib). The actual filename is declared in the "main" field of manifest.json (e.g. "darwin-arm64-dev": "calc_ui_cpp_plugin.dylib"). The discovery logic was looking for the wrong file and not finding installed plugins.
Same root cause. The path returned for loading a C++ plugin was constructed from the directory name rather than the "main" field, so QPluginLoader was pointed at a non-existent path.