Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a tests/README.md to document how to run the Qt-based test suite, and fixes the macOS development shell (nix develop) by replicating the install_name_tool rpath fixup — already present in preConfigure for the build — into the shellHook as well, so that dylib files are correctly configured when working in the dev shell on macOS.
Changes:
- Added
tests/README.mddocumentingctestand direct-executable invocation for all three test targets. - Extended
flake.nix'sdevShells.default.shellHookto runinstall_name_tool -id "@rpath/..."on copied.dylibfiles, mirroring the existing macOS fix inpreConfigure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/README.md |
New file documenting how to run the async, sync, and integration tests via ctest or directly. |
flake.nix |
Adds the macOS install_name_tool rpath fixup block to the dev shell's shellHook to mirror the build-time fix. |
The one minor observation is in tests/README.md: the commands (e.g., ctest --test-dir build, ./build/async) must be run from the repository root, not from inside the tests/ subdirectory. Since this README lives in tests/, a reader might naturally try running the commands from there and get confusing errors. Adding a brief note clarifying the working directory would improve usability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.