Skip to content

test: add readme and fix examples on macos#31

Merged
gmelodie merged 3 commits intomasterfrom
test-readme
Mar 5, 2026
Merged

test: add readme and fix examples on macos#31
gmelodie merged 3 commits intomasterfrom
test-readme

Conversation

@rlve
Copy link
Collaborator

@rlve rlve commented Mar 3, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 12:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a tests/README.md to document how to run the Qt-based test suite, and fixes the macOS development shell (nix develop) by replicating the install_name_tool rpath fixup — already present in preConfigure for the build — into the shellHook as well, so that dylib files are correctly configured when working in the dev shell on macOS.

Changes:

  • Added tests/README.md documenting ctest and direct-executable invocation for all three test targets.
  • Extended flake.nix's devShells.default.shellHook to run install_name_tool -id "@rpath/..." on copied .dylib files, mirroring the existing macOS fix in preConfigure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/README.md New file documenting how to run the async, sync, and integration tests via ctest or directly.
flake.nix Adds the macOS install_name_tool rpath fixup block to the dev shell's shellHook to mirror the build-time fix.

The one minor observation is in tests/README.md: the commands (e.g., ctest --test-dir build, ./build/async) must be run from the repository root, not from inside the tests/ subdirectory. Since this README lives in tests/, a reader might naturally try running the commands from there and get confusing errors. Adding a brief note clarifying the working directory would improve usability.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gmelodie gmelodie merged commit 4ee580f into master Mar 5, 2026
8 checks passed
@rlve rlve deleted the test-readme branch March 10, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants