Skip to content

test: kad integration tests#37

Merged
rlve merged 13 commits intomasterfrom
test-4
Mar 13, 2026
Merged

test: kad integration tests#37
rlve merged 13 commits intomasterfrom
test-4

Conversation

@rlve
Copy link
Collaborator

@rlve rlve commented Mar 11, 2026

@rlve rlve marked this pull request as ready for review March 12, 2026 09:57
@rlve rlve requested a review from Copilot March 12, 2026 09:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated QtTest integration test executable for Kademlia (Kad) behaviors, separating Kad scenarios out of the existing integration suite and updating the Nix flake lock to a newer nim-libp2p revision (per the dependency noted in the PR description).

Changes:

  • Introduce tests/integration_kad.cpp with integration coverage for Kad put/get, find-node, providing lifecycle, and random-records.
  • Remove the older kadPutGet() scenario from tests/integration.cpp (now moved/refined into the new Kad-focused test file).
  • Update flake.lock to pin nim-libp2p to a newer commit.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.

File Description
tests/integration_kad.cpp New Kad-focused integration test executable covering multiple Kad operations.
tests/integration.cpp Removes the prior inline Kad put/get integration test.
flake.lock Bumps pinned nim-libp2p revision used by Nix builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gmelodie
Copy link
Collaborator

@rlve I merged test-3 before this one, can you point this PR to master?

Base automatically changed from test-3 to master March 13, 2026 09:51
@rlve rlve merged commit e02cfba into master Mar 13, 2026
4 checks passed
@rlve rlve deleted the test-4 branch March 13, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants