Conversation
1 task
There was a problem hiding this comment.
Pull request overview
Adds a dedicated QtTest integration test executable for Kademlia (Kad) behaviors, separating Kad scenarios out of the existing integration suite and updating the Nix flake lock to a newer nim-libp2p revision (per the dependency noted in the PR description).
Changes:
- Introduce
tests/integration_kad.cppwith integration coverage for Kad put/get, find-node, providing lifecycle, and random-records. - Remove the older
kadPutGet()scenario fromtests/integration.cpp(now moved/refined into the new Kad-focused test file). - Update
flake.lockto pinnim-libp2pto a newer commit.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tests/integration_kad.cpp | New Kad-focused integration test executable covering multiple Kad operations. |
| tests/integration.cpp | Removes the prior inline Kad put/get integration test. |
| flake.lock | Bumps pinned nim-libp2p revision used by Nix builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@rlve I merged test-3 before this one, can you point this PR to master? |
gmelodie
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: vacp2p/nim-libp2p#2149