Ensure library and binary are portable; add CI actions to check#10
Open
iurimatias wants to merge 5 commits intomasterfrom
Open
Ensure library and binary are portable; add CI actions to check#10iurimatias wants to merge 5 commits intomasterfrom
iurimatias wants to merge 5 commits intomasterfrom
Conversation
iurimatias
force-pushed
the
fix_nix_references
branch
from
f5ef2cb to
320803f
Compare
dlipicar
force-pushed
the
fix_nix_references
branch
from
4751d64 to
0ec93d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the issue with hardcoded /nix/ paths; fixes the lib to look for the dependencies into specific places; and adds scripts to check for these sort of issues. also adds CI / github action to check for this so it's not accidentally re-introduced in the future