Conversation
iurimatias
approved these changes
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds an icon field to the manifest structure of LGX packages, allowing packages to specify a relative path to an icon file bundled within the package. The implementation follows the same pattern as other metadata fields like description, author, and category.
Changes:
- Added
iconfield as a required string field to the manifest schema (can be empty string) - Added C API functions
lgx_get_icon()andlgx_set_icon()for accessing icon metadata - Updated documentation to reflect the new field in package specifications
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/manifest.h | Added icon field declaration to Manifest class |
| src/core/manifest.cpp | Added icon field initialization, JSON parsing validation, and serialization |
| src/core/package.cpp | Initialized icon field to empty string in package creation |
| src/lgx.h | Added C API declarations for lgx_get_icon() and lgx_set_icon() |
| src/lib.cpp | Added C API implementations with caching and error handling |
| tests/test_manifest.cpp | Added comprehensive tests for icon field parsing, missing icon validation, and roundtrip serialization |
| tests/test_lib.cpp | Added API tests for icon getter/setter functions and null handling |
| docs/spec.md | Updated manifest schema documentation and default values |
| docs/project.md | Updated C API documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c2e1200 to
82d94f5
Compare
82d94f5 to
e9b6701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.