Skip to content

add icon field to manifest#14

Merged
dlipicar merged 2 commits intomasterfrom
add-icon-to-manifest
Feb 23, 2026
Merged

add icon field to manifest#14
dlipicar merged 2 commits intomasterfrom
add-icon-to-manifest

Conversation

@dlipicar
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 23, 2026 21:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds an icon field to the manifest structure of LGX packages, allowing packages to specify a relative path to an icon file bundled within the package. The implementation follows the same pattern as other metadata fields like description, author, and category.

Changes:

  • Added icon field as a required string field to the manifest schema (can be empty string)
  • Added C API functions lgx_get_icon() and lgx_set_icon() for accessing icon metadata
  • Updated documentation to reflect the new field in package specifications

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/core/manifest.h Added icon field declaration to Manifest class
src/core/manifest.cpp Added icon field initialization, JSON parsing validation, and serialization
src/core/package.cpp Initialized icon field to empty string in package creation
src/lgx.h Added C API declarations for lgx_get_icon() and lgx_set_icon()
src/lib.cpp Added C API implementations with caching and error handling
tests/test_manifest.cpp Added comprehensive tests for icon field parsing, missing icon validation, and roundtrip serialization
tests/test_lib.cpp Added API tests for icon getter/setter functions and null handling
docs/spec.md Updated manifest schema documentation and default values
docs/project.md Updated C API documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dlipicar dlipicar force-pushed the add-icon-to-manifest branch 9 times, most recently from c2e1200 to 82d94f5 Compare February 23, 2026 22:48
@dlipicar dlipicar force-pushed the add-icon-to-manifest branch from 82d94f5 to e9b6701 Compare February 23, 2026 22:52
@dlipicar dlipicar merged commit d9a7413 into master Feb 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants