chore: add throttle for download and upload operations#19
Merged
Conversation
emizzle
approved these changes
Mar 18, 2026
| // | ||
| // Progress events are throttled to at most one per percentage point (max 100 | ||
| // events total) to avoid flooding the caller with events on every block. | ||
| // When totalBytes is 0 (unknown), every event is forwarded without throttling. |
Collaborator
There was a problem hiding this comment.
When would totalBytes be zero? I don't think the manifest will ever be missing this information, but i guess it doesn't hurt to have this contingency.
Collaborator
Author
There was a problem hiding this comment.
If the manifest download failed for some reason, or if downloadChunks is called directly, not internally by downloadToUrl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds throttle for download and upload operation in order to better handle big files.