Skip to content

support all flake outputs#15

Merged
dlipicar merged 1 commit intomasterfrom
support-flake-outputs
Mar 18, 2026
Merged

support all flake outputs#15
dlipicar merged 1 commit intomasterfrom
support-flake-outputs

Conversation

@dlipicar
Copy link
Contributor

Only the default output could be built before. Now we support stuff like ws build logos-basecamp#bin-bundle-dir

Copilot AI review requested due to automatic review settings March 18, 2026 19:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the workspace build flow to allow targeting non-default flake package outputs per repo (e.g., ws build logos-basecamp#portable) by exposing repo outputs through the workspace flake and teaching ws build to reference them.

Changes:

  • Update ws build to accept repo#output and translate it into the workspace flake attribute naming scheme.
  • Update flake.nix to forward all per-repo packages.<system> outputs into the workspace flake as repo (default) and repo--output (non-default).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/ws Parses repo#output and builds the corresponding WORKSPACE_ROOT#<input>--<output> reference.
flake.nix Exposes all sub-repo package outputs under workspace packages to make non-default outputs buildable.

You can also share your feedback on Copilot code review. Take the survey.

@dlipicar dlipicar merged commit df71614 into master Mar 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants