Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the workspace build flow to allow targeting non-default flake package outputs per repo (e.g., ws build logos-basecamp#portable) by exposing repo outputs through the workspace flake and teaching ws build to reference them.
Changes:
- Update
ws buildto acceptrepo#outputand translate it into the workspace flake attribute naming scheme. - Update
flake.nixto forward all per-repopackages.<system>outputs into the workspace flake asrepo(default) andrepo--output(non-default).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/ws |
Parses repo#output and builds the corresponding WORKSPACE_ROOT#<input>--<output> reference. |
flake.nix |
Exposes all sub-repo package outputs under workspace packages to make non-default outputs buildable. |
You can also share your feedback on Copilot code review. Take the survey.
iurimatias
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the default output could be built before. Now we support stuff like
ws build logos-basecamp#bin-bundle-dir