Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions CI workflow to use Cachix-based Nix installation and binary caching, aiming to speed up Nix builds in PR CI runs.
Changes:
- Switch Nix installer action to
cachix/install-nix-action@v27and explicitly enable flakes viaextra_nix_config. - Replace Determinate Systems cache action with
cachix/cachix-action@v15configured for thelogos-cocache.
| uses: cachix/cachix-action@v15 | ||
| with: | ||
| name: logos-co | ||
| authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' |
There was a problem hiding this comment.
cachix/cachix-action will enable pushing to the Cachix cache when authToken is provided. Since this workflow runs on pull_request, PR builds would upload outputs from unreviewed code and can also fail on forked PRs where secrets.CACHIX_AUTH_TOKEN is unavailable. Consider omitting authToken for PRs (pull-only cache) and only enabling it for trusted events (e.g., push to master or non-fork PRs via an if: guard).
Suggested change
| authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.