Skip to content

Correctly handle reads by the input module that are not aligned to a newline #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Correctly handle reads by the input module that are not aligned to a newline #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions lib/logstash/codecs/multiline.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,25 @@ def accept(listener)
end

def decode(text, &block)
text = @converter.convert(text)
text.split("\n").each do |line|
parts = text.split("\n")

# oftentimes the sysread done by the input plugin
# is not perfectly aligned with newlines. In these
# cases (no newline at string ending) we keep that part
# as a carry over and will reattach it at the next
# decode call

if @carry_over
parts[0] = @carry_over + parts[0]
@carry_over = nil
end

unless text =~ /\n\Z/
@carry_over = parts.pop
end

parts.each do |line|
line = @converter.convert(line)
match = @grok.match(line)
@logger.debug("Multiline", :pattern => @pattern, :text => line,
:match => !match.nil?, :negate => @negate)
Expand Down