186-custom-headers #187
186-custom-headers #187
Conversation
robbavey
left a comment
robbavey
left a comment
There was a problem hiding this comment.
Don't forget to bump version info, and add changelog entry.
Co-authored-by: kaisecheng <[email protected]>
|
Changes look good to me.
Let me know if you need any help. |
|
I have cur 3.x correctly and changed this PR's base branch. |
Co-authored-by: Mashhur <[email protected]>
|
@mashhurs Can you tell me why this feature need to be on top of 3.x but not the usual workflow to 4.1.0? |
|
I think it's because of the changes we're making to SSL settings. That we want to wait for a major version change for that, but this is a minor change that we want to release sooner. |
|
@flexitrev es-filter 4.0.0 is already published. If you release 3.17.0 now, the custom headers feature will be available in 3.17.0 but not 4.0.0, which is confusing. This is not a normal workflow we do in plugin release |
|
To @kaisecheng's point - this work needs to be in both The usual workflow of committing into If we proceed with targeting against |
* Mark previously deprecated SSL settings as obsolete - SSL settings that were marked deprecated in version `3.15.0` are now marked obsolete, and will prevent the plugin from starting. - These settings are: - `ca_file`, which should be replaced by `ssl_certificate_authorities` - `keystore`, which should be replaced by `ssl_keystore_path` - `keystore_password`, which should be replaced by `ssl_keystore_password` - `keystore_type`, which should be replaced by `ssl_keystore_password` - `ssl`, which should be replaced by `ssl_enabled`
|
Rebased from main. Let me know if there's any outstanding issues, and I'll merge into main |
|
@flexitrev This has been rebased against |
|
Merged by #188 |
This adds custom header support.
custom_headers => {"Key" => "Value"} will be added to requests. Supports use of API keys and bearer tokens