-
Couldn't load subscription status.
- Fork 86
Remove non available stack release versions from integration CI tests #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non available stack release versions from integration CI tests #204
Conversation
spec/filters/elasticsearch_spec.rb
Outdated
| require "logstash/filters/elasticsearch" | ||
| require "logstash/json" | ||
| require "cabin" | ||
| require "manticore" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we want to remove tests using manticore, yes we need it. Looks like that dependency was removed from any of the previous requires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a link to a failed run where you saw this? It looks to me like this is currently running fine https://app.travis-ci.com/github/logstash-plugins/logstash-input-elasticsearch/jobs/635313527
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donoghuc the link you have posted is belong to input-elasticsearch, this is filter-elasticsearch but input-es is also with the same case.
I have seen this issue in the past -https://app.travis-ci.com/github/logstash-plugins/logstash-filter-elasticsearch/jobs/635410594
And it looks like transient. I have retried it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it is 🟢
bfe3040 to
5ca704e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor suggestion that the failure is actually transient.
5ca704e to
60ca018
Compare
Plugin CI is broken as we can see in this PR. The reason is that the plugin CI file includes an stack release version that is not available (
8.next). This is referenced at: https://github.com/logstash-plugins/.ci/blob/1.x/logstash-versions.yml.This commit removes unavailable release from integration tests jobs definition to fix the CI.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/