Skip to content

Conversation

@alexcams
Copy link
Contributor

@alexcams alexcams commented Sep 18, 2025

Plugin CI is broken as we can see in this PR. The reason is that the plugin CI file includes an stack release version that is not available (8.next). This is referenced at: https://github.com/logstash-plugins/.ci/blob/1.x/logstash-versions.yml.

This commit removes unavailable release from integration tests jobs definition to fix the CI.

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@alexcams alexcams marked this pull request as draft September 18, 2025 10:42
require "logstash/filters/elasticsearch"
require "logstash/json"
require "cabin"
require "manticore"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need?

Copy link
Contributor Author

@alexcams alexcams Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we want to remove tests using manticore, yes we need it. Looks like that dependency was removed from any of the previous requires.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to a failed run where you saw this? It looks to me like this is currently running fine https://app.travis-ci.com/github/logstash-plugins/logstash-input-elasticsearch/jobs/635313527

Copy link
Contributor

@mashhurs mashhurs Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donoghuc the link you have posted is belong to input-elasticsearch, this is filter-elasticsearch but input-es is also with the same case.
I have seen this issue in the past -https://app.travis-ci.com/github/logstash-plugins/logstash-filter-elasticsearch/jobs/635410594
And it looks like transient. I have retried it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it is 🟢

@alexcams alexcams force-pushed the remove-CI-versions-not-available branch from bfe3040 to 5ca704e Compare September 19, 2025 07:38
@alexcams alexcams marked this pull request as ready for review September 19, 2025 08:11
@alexcams alexcams requested a review from mashhurs September 19, 2025 10:17
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion that the failure is actually transient.

@alexcams alexcams force-pushed the remove-CI-versions-not-available branch from 5ca704e to 60ca018 Compare September 22, 2025 08:04
@alexcams alexcams merged commit b9dd093 into logstash-plugins:main Sep 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants