Skip to content

Conversation

@alexcams
Copy link
Contributor

@alexcams alexcams commented Oct 17, 2025

There was a CI transient error while executing elasticsearch_spec.rb unit tests that was making pipelines fail from time to time:
Uninitialized Manticore error
image

This is a concurrency error caused by the indirect inclusion of Manticore library while calling this function that is called by many tests in elasticsearch_spec.rb file. Since the tests execution does not always follow the same order, the problem comes if any test that use Manticore::Client class is executed before calling this function that indirectly includes the Manticore library, it causes this class to be "uninitialized".

To solve this transient error, I've just included the Manticore lib at the beginning of the file.

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@jsvd
Copy link
Member

jsvd commented Oct 17, 2025

Tests are failing due to fixture certs expiring, please run spec/filters/fixtures/generate_test_certs.sh and commit the new certs to this PR

@alexcams alexcams force-pushed the fix-unit-tests-transient-error-uninitialized-manticore branch from 5295e29 to f9d7b79 Compare October 17, 2025 14:43
@alexcams alexcams requested a review from jsvd October 17, 2025 15:25
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexcams alexcams merged commit 2a7bfa4 into logstash-plugins:main Oct 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants