restoring call to decorate(event) for common options to work #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3.3.0, the call to decorate(event) was removed, meaning "common options" such as add_field and tags were no longer applied to the event. This PR restores that functionality
|
Closing as this has already been corrected in #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.3.0, the call to decorate(event) was removed, meaning "common options" such as add_field and tags were no longer applied to the event. This PR tries to restore that functionality.
Where it was removed : 4a1530f#diff-2e09dad818d884b899bb96bc87f8149d81e57fa45aedf8251ce95fe73118445aL330
Code for the original function : https://github.com/elastic/logstash/blob/main/logstash-core/lib/logstash/inputs/base.rb#L135-L141