Skip to content

Conversation

@nevins-b
Copy link

@nevins-b nevins-b commented Feb 8, 2018

No description provided.

@nevins-b
Copy link
Author

hmm the failure seems to be the same as logstash-plugins/logstash-input-kafka#241, I'm not sure what the correct fix for this issue

@jakelandis
Copy link
Contributor

jakelandis commented Feb 15, 2018

@nevins-b - thanks for the contribution. I wouldn't worry about the 5.x failure, it is obviously unrelated to your changes. However, we do prefer independent verification, and I am not personally setup to test this.

Requesting a community member to test this PR

To get this changes on this PR locally:

git clone https://github.com/logstash-plugins/logstash-input-kinesis.git
cd logstash-input-kinesis
curl -s https://patch-diff.githubusercontent.com/raw/logstash-plugins/logstash-input-kinesis/pull/36.patch | git apply

@nevins-b - can you provide detailed instructions for how to test this ?

@jakelandis jakelandis removed their request for review December 11, 2018 18:29
@ghost
Copy link

ghost commented Dec 11, 2018

Hi @nevins-b, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants