-
Couldn't load subscription status.
- Fork 62
Upgrade Kafka client to v4 #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Kafka client to v4 #205
Conversation
update download url
- added jackson-datatype-jdk8
- Avro class renamed
AbstractKafkaAvroSerDeConfig is renamed to AbstractKafkaSchemaSerDeConfig
- kafka-output `partitioner` classes are removed
UniformStickyPartitioner and DefaultPartitioner are removed
only `round_robin` and `uniform_sticky` are available
- kafka-client DeleteTopicsResult values() is deprecated
used topicNameValues() instead
- doc changed the default behaviour of `partitioner`
757b7c5 to
b6cbe0b
Compare
| if [[ "$KAFKA_MAJOR_VERSION" -eq 3 ]]; then | ||
| cp "spec/fixtures/jaas$KAFKA_MAJOR_VERSION.config" "build/confluent_platform/etc/schema-registry/jaas.config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI only tests against Kafka 4. Keeping old jaas.config for development testing against Kafka 3.
Align with Kafka client 4.0 default value change
…ash-integration-kafka into upgrade_kafka_client_v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please bump the version on the integration .gemspec
I have updated logstash-integration-kafka.gemspec to 12.0.0. Do I miss anything? |
|
my bad, I blame github always linking only to the changes since the last commit instead of the entire PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor documentation tweak, otherwise LGTM
Co-authored-by: João Duarte <[email protected]>
defaultanduniform_stickyare removed. This is a breaking change.linger_msdefault value changed from 0 to 5group_protocolsoptions for configuring new consumer rebalance protocolconsumeropts in to the new consumer group protocolpartition_assignment_strategy,heartbeat_interval_msandsession_timeout_msclassicis the default protocolNotable change in Kafka 4
Author's Checklist
Related issues
PR: #206
Closes #195