Skip to content

refactor: remove dependency serialize-error#131

Merged
PetrHeinz merged 1 commit intologtail:masterfrom
CHC383:refactor/remove-serialize-error
Apr 15, 2025
Merged

refactor: remove dependency serialize-error#131
PetrHeinz merged 1 commit intologtail:masterfrom
CHC383:refactor/remove-serialize-error

Conversation

@CHC383
Copy link
Contributor

@CHC383 CHC383 commented Jan 24, 2025

Remove dependency serialize-error from package edge and node as there are no references in the code.

I was trying to upgrade serialize-error to close #128. Although I couldn't achieve that due to serialize-error becomes pure ESM package since 9.0 while this repository still generates CJS outputs, I found out serialize-error is not in used in some packages.

@curusarn
Copy link
Contributor

Thank you for the PR @CHC383!
I appreciate it.

I'll pass this on to the team to review and merge.

Thanks again for the contribution!

Copy link
Member

@PetrHeinz PetrHeinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CHC383 and thanks for the PR!

Sincere apologies for the long wait 🙏

@PetrHeinz PetrHeinz merged commit a8fe98a into logtail:master Apr 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why still on serialize-error@8?

3 participants