T-8088 Add gzip compression to node and edge sync functions #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrHeinz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gzip compression to sync functions in
nodeandedgepackage (also used in packages such aspinoorwinston).This should significantly lower the egress network traffic in backend services.
Wanted to add compression to
browserpackage as well, but it would require an additional dependency (e.g. https://github.com/nodeca/pako) and is not worth the additional complexity imo. Requests from browsers tend to be smaller and the extra upload size is not much of an issue.Planning on releasing this as
v0.5.5.