Skip to content

Conversation

@PetrHeinz
Copy link
Member

@PetrHeinz PetrHeinz commented Mar 10, 2025

Previously, Content-Encoding gzip was sent, but deflate was used to compress the data

Fixes #34

@PetrHeinz PetrHeinz requested a review from adikus March 10, 2025 16:15
@PetrHeinz PetrHeinz changed the title Ph/deflate header T-6088 Send correct Content-Encoding HTTP header Mar 10, 2025
@gyfis
Copy link
Contributor

gyfis commented Mar 10, 2025

@PetrHeinz do you want to go the other way around, e.g. gzip the actual data instead? That should give better default compression

@PetrHeinz
Copy link
Member Author

@gyfis Tried to do it in #38 , but doesn't seem to be working when run against real ingestion. I'd merge it with the deflate compression. WDYT?

@adikus
Copy link
Contributor

adikus commented Mar 10, 2025

@gyfis Deflate and gzip are the same compression, they only differ in headers from what I understand, so should be no difference in compression levels.

@gyfis
Copy link
Contributor

gyfis commented Mar 10, 2025

Ah, my bad then, sorry! Got confused as well

@PetrHeinz PetrHeinz merged commit b5f0773 into main Mar 10, 2025
13 checks passed
@PetrHeinz PetrHeinz deleted the ph/deflate-header branch March 10, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants